Ask to merge AmigaOS4 port of SMTube in your svn

[rvm]

I think the errorWindow code should be implemented in its own files (errorwindow.h/cpp), and not in ytdialog. That way it would be easier to use it if in the future it's necessary to call it from another class.

[zzd10h]

I just do that this evening, I will send you the new errorWindow.h/.cpp files tomorrow.

[zzd10h]

I have added the errorWindow Class in the latest 6515 revision

1) created 2 files erroramiga.h and erroramiga.cpp

http://zzd10h.amiga-ng.org/Qt/SMTube/er ... vn6515.zip

2) added them to smtube.pro

http://zzd10h.amiga-ng.org/Qt/SMTube/sm ... 5.diff.zip

3) called the errorWindow window into ytdialog.cpp

http://zzd10h.amiga-ng.org/Qt/SMTube/yt ... 5.diff.zip

4) and added a picture in Amiga directory

http://zzd10h.amiga-ng.org/Qt/SMTube/Amiga_svn6515.zip


Is it OK ?

Thank you
Guillaume

[rvm]

I've just commited it (r6532), although I made some changes. Let me know if it works.

About the icon, it includes the Youtube logo, I don't know if it's possible to use it.

[zzd10h]

Thank you for the changes and for the commit.
It compiles and works great !

For the picture, could you take this new Amiga directory ?

http://zzd10h.amiga-ng.org/Qt/SMTube/Amiga_svn6532.zip

It contains the SMPlayer picture from http://smplayer.sourceforge.net/images/ ... player.png


Nothing related, but your previous revision was "added option to use https or http" where is this option ?

Thank you
Guillaume

[rvm]

[zzd10h]

On AmigaOS4, we don't read .ico file.
Do you prefer that I take the ./icons/logo.png ?

Thx for https reply.

[zzd10h]

I just tested the function that you use in about.cpp

picture->setPixmap( QPixmap(":/icons/logo.png").scaledToHeight(64, Qt::SmoothTransformation) );

instead of

picture->setPixmap(QPixmap("Amiga/SMTube.png"));


It's great !

Do you prefer that ?
If yes, do you want that I resend a diff file and a new Amiga directory without the smtube.png ?

[rvm]

I've just made that change in erroramiga.cpp (r6538).

[zzd10h]

Thank you,
compiled and tested. All is OK